Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell generic-builder: Support installing internal libs. #32993

Merged
merged 1 commit into from Dec 29, 2017
Merged

haskell generic-builder: Support installing internal libs. #32993

merged 1 commit into from Dec 29, 2017

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Dec 23, 2017

Fixes #32980.

@shlevy shlevy requested a review from peti December 23, 2017 00:26
@shlevy
Copy link
Member Author

shlevy commented Dec 23, 2017

Note: tests are still running locally and this is a mass-rebuild, @peti do we just use staging for mass-haskell rebuilds these days?

@shlevy
Copy link
Member Author

shlevy commented Dec 23, 2017

Already found some bugs, please hold 😄

@shlevy
Copy link
Member Author

shlevy commented Dec 23, 2017

OK, I've tested the current locally by only enabling it for haddock-library_1_4_4 on my haskell-ide-engine PR, now going to test with it enabled for all haskell and will leave it overnight.

@grahamc
Copy link
Member

grahamc commented Dec 23, 2017

@GrahamcOfBorg eval

(sorry for the noise, master was broken by a merge)

@shlevy
Copy link
Member Author

shlevy commented Dec 23, 2017

OK was able to fully build ghc-ide-engine, including haddock-library_1_4_4 with its internal libraries, on top of this PR.

@shlevy shlevy mentioned this pull request Dec 23, 2017
Merged
@peti peti self-assigned this Dec 28, 2017
@peti
Copy link
Member

peti commented Dec 28, 2017

I'm waiting for the ghc-rebuilds to finish on Hydra. Once those changes are verified, then I'll tackle this subject.

This was referenced Dec 28, 2017
Closed
Closed
@peti
Copy link
Member

peti commented Dec 28, 2017

Pushed to test branch as 84d16e7400d89acd9c49bf3c60d9279be39b9273. Builds are running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates.

@peti peti merged commit 504016f into NixOS:master Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees

@peti peti

Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shlevy @grahamc @peti @domenkozar @GrahamcOfBorg