Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 5.2.2 -> 5.2.4 #32983

Merged
merged 4 commits into from Dec 23, 2017
Merged

virtualbox: 5.2.2 -> 5.2.4 #32983

merged 4 commits into from Dec 23, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 22, 2017 •
edited

Motivation for this change

This bumps virtualbox to version 5.2.4, adds its license and me as a maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Dec 22, 2017

This package is especially sensitive to nox-review, and it has a NixOS test in nixos/tests/virtualbox.nix. Knowing that will help you as a maintainer :)

@flokli
Copy link
Contributor Author

flokli commented Dec 23, 2017

@orivej Of course you're right, missed them 😊 Tests also showed I forgot to update the sha256sum of virtualBoxGuestAdditions, which is now fixed.

The tests seemed to mknod /dev/vda1, which already existed, so the tests failed (and most likely did before, too). This is fixed, too.

I have no idea why @GrahamcOfBorg complains about xen here, maybe @grahamc has an idea?

@orivej
Copy link
Contributor

orivej commented Dec 23, 2017

Thank you! The tests were broken by 0d27df2 (as can be seen at https://hydra.nixos.org/build/65928567). /cc @dezgeg (not to blame, but to inform).

orivej
orivej approved these changes Dec 23, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this up a bit and consider it ready to merge.

@grahamc
Copy link
Member

grahamc commented Dec 23, 2017

@GrahamcOfBorg eval

(sorry for the noise, master was broken by a merge)

@orivej orivej merged commit c3cfdc1 into NixOS:master Dec 23, 2017
@flokli flokli deleted the virtualbox-5.2.4 branch December 23, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @orivej @grahamc @GrahamcOfBorg