init devpi-server at 4.3.1, bump devpi-client #32335
Conversation
|
@GrahamcOfBorg build devpi-client devpi-server |
There was a problem hiding this comment.
Success for system: x86_64-linux
=============================== warnings summary ===============================
None
Module already imported so can not be re-written: _pytest.pytester
-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 1 tests deselected ==============================
====== 182 passed, 2 skipped, 1 deselected, 1 warnings in 423.22 seconds =======
/nix/store/nwpi23zfcr48cxgw66fq84lh2ljv8gxr-devpi-client-3.1.0
/nix/store/4dl5a6vk25i7jml785wfcmjw7w38jncp-devpi-server-4.3.1
| inherit pname version; | ||
| sha256 = "1kdp6qbh5v1168l99rba5yfzvy05gmzkmkhldgp36p9xcdjd5dv8"; | ||
| }; | ||
| buildInputs = [ pytest ]; |
There was a problem hiding this comment.
I took pytest-xdist, `pytest-datafiles as reference, none of them seems to use pytest as propagated build input
There was a problem hiding this comment.
Correct. pytest plugins do not propagate pytest because it should be possible to use a different pytest with a certain plugin.
pkgs/top-level/python-packages.nix
Outdated
|
|
||
| argon2_cffi = callPackage ../development/python-modules/argon2_cffi { }; | ||
|
|
||
| pytest-timeout = callPackage ../development/python-modules/pytest-timeout { }; |
There was a problem hiding this comment.
@FRidh does not like just appending new packages to the end :)
There was a problem hiding this comment.
python-packages is fubar, with multiple beginnings and endings
There was a problem hiding this comment.
I don't like it? Well, we should aim at having ordering. PR's that improve ordering are more than welcome.
There was a problem hiding this comment.
I will have a look into it, but not for this PR ;)
There was a problem hiding this comment.
Even partial order should help to avoid merge conflicts.
There was a problem hiding this comment.
I just tried my best to add them somewhere ...
| inherit pname version; | ||
| sha256 = "1kdp6qbh5v1168l99rba5yfzvy05gmzkmkhldgp36p9xcdjd5dv8"; | ||
| }; | ||
| buildInputs = [ pytest ]; |
There was a problem hiding this comment.
Correct. pytest plugins do not propagate pytest because it should be possible to use a different pytest with a certain plugin.
| { stdenv | ||
| , lib | ||
| , python | ||
| , python3 |
There was a problem hiding this comment.
python3 is not used. Also, don't pass both python and pythonPackages. Both already contain references to each other.
There was a problem hiding this comment.
you are right, this is a leftover from the times where i've tried to get the test_test.py tests running but failed in providing a python version with setuptools to the tox environment
makefu
force-pushed
the
pkgs/devpi-common/update
branch
from
87de3e1
to
ffce662
Compare
|
@GrahamcOfBorg eval |
GrahamcOfBorg
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
makefu
force-pushed
the
pkgs/devpi-common/update
branch
from
ffce662
to
7e39ecb
Compare
|
thanks! |
Motivation for this change
This PR introduces devpi-server to nixpkgs. For this PR, argon2 needs to be supported by passlib.
With the devpi-server package it is possible to re-enable tests for devpi-client, however a couple of tests needed to be disabled because of issues with tox and setuptools.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)waiting for you, @GrahamcOfBorg ;)