Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox: fix version sort order #32328

Merged
merged 1 commit into from Dec 5, 2017
Merged

dropbox: fix version sort order #32328

merged 1 commit into from Dec 5, 2017

Conversation

benley
Copy link
Member

@benley benley commented Dec 5, 2017

This makes the startup wrapper work as intended instead of deleting, re-downloading, and downgrading Dropbox after each time it updates itself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@benley
dropbox: fix version sort order
7a9784c 
This makes the startup wrapper work as intended instead of
re-downgrading Dropbox after each time it updates itself.
@benley benley requested a review from ttuegel December 5, 2017 04:26
@ttuegel
Copy link
Member

ttuegel commented Dec 5, 2017

Wow, I am not smart. Thanks for catching this!

@ttuegel ttuegel merged commit f3cf114 into NixOS:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @ttuegel @GrahamcOfBorg