r2-cutter: init at 1.0(.0), radare2 qt gui #32345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
force-pushed
the
feature/r2-cutter
branch
from
f2f3bf8
to
769960b
Compare
|
Switched to using qmake instead of cmake since a)documentation says it's the "official" way and b)no custom install phase needed |
Naming "r2-cutter" since "cutter" already exists, but AFAIK this naming is not used anywhere else currently.
dtzWill
force-pushed
the
feature/r2-cutter
branch
from
1fb340d
to
56a05d9
Compare
|
Grabbed some fixes from upstream and ensure an icon, and the "right" icon, is installed. Should be good to go now 👍. |
8 tasks
|
Closing in favor of #33198. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming "r2-cutter" since "cutter" already exists,
but AFAIK this naming is not used anywhere else currently.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)