Semantic: fix to look up type var in macro called inside class #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bew
reviewed
Dec 5, 2017
| @free_vars_cache = {} of GenericInstanceType => Hash(String, TypeVar) | ||
|
|
||
| private def macro_free_vars_for_type(type) | ||
| unless free_vars = @free_vars_cache[type]? |
There was a problem hiding this comment.
Maybe use the following syntax?
@free_vars_cache[type] ||= begin
# build the value for this *type* here
endThis will get the value associated with type, and if there is none, build the value and associate it with type in the hash, and return it.
makenowjust
force-pushed
the
fix/crystal/lookup-type-var-in-macro-called-in-class
branch
from
ab95e27
to
1e846c9
Compare
RX14
approved these changes
Dec 5, 2017
|
Hmm now we have a (maybe?) unwanted behavior: class Foo(T)
macro foo(node)
{{node.resolve}}
end
end
alias FooInt32 = Foo(Int32)
class Bar
def self.foo
FooInt32.foo T
end
end
p Bar.foo # => Int32What I want to hightlight here is that in Maybe it's not an issue after all, but this is definitely not documented, and is unexpected for a |
|
I think this can be closed in favor of #5354. |
|
@makenowjust what is the status of this PR? |
|
#5354 has been merged, we can close this pr now |
|
@bew Yes. I'll close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5343