Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: 6.9.9-23 -> 6.9.9-26 #32343

Merged
merged 1 commit into from Dec 11, 2017
Merged

imagemagick: 6.9.9-23 -> 6.9.9-26 #32343

merged 1 commit into from Dec 11, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

New upstream version, source tarball for 6.9.9-23 is no longer available on any of the mirrors

Please also backport to 17.09 as this causes build failures.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 5, 2017
@Mic92
Copy link
Member

Mic92 commented Dec 5, 2017

@GrahamcOfBorg build imagemagick

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 5, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/qnfq2i6yfvsaq669pfypdq6dvg3xfz3h-imagemagick-6.9.9-25-dev/bin/Wand-config: interpreter directive changed from "/bin/sh" to "/nix/store/ski5znw2b8bj5qnsncrcq6128hkrwgvq-bash-4.4-p12/bin/sh"
/nix/store/qnfq2i6yfvsaq669pfypdq6dvg3xfz3h-imagemagick-6.9.9-25-dev/bin/Magick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/ski5znw2b8bj5qnsncrcq6128hkrwgvq-bash-4.4-p12/bin/sh"
/nix/store/qnfq2i6yfvsaq669pfypdq6dvg3xfz3h-imagemagick-6.9.9-25-dev/bin/MagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/ski5znw2b8bj5qnsncrcq6128hkrwgvq-bash-4.4-p12/bin/sh"
/nix/store/qnfq2i6yfvsaq669pfypdq6dvg3xfz3h-imagemagick-6.9.9-25-dev/bin/Magick-config: interpreter directive changed from "/bin/sh" to "/nix/store/ski5znw2b8bj5qnsncrcq6128hkrwgvq-bash-4.4-p12/bin/sh"
/nix/store/qnfq2i6yfvsaq669pfypdq6dvg3xfz3h-imagemagick-6.9.9-25-dev/bin/MagickCore-config: interpreter directive changed from "/bin/sh" to "/nix/store/ski5znw2b8bj5qnsncrcq6128hkrwgvq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-imagemagick-6.9.9-25.drv-0 in /nix/store/qnfq2i6yfvsaq669pfypdq6dvg3xfz3h-imagemagick-6.9.9-25-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/hv2n92d7zd7dkiwwwnffsr08bh0b5syp-imagemagick-6.9.9-25-doc
patching script interpreter paths in /nix/store/hv2n92d7zd7dkiwwwnffsr08bh0b5syp-imagemagick-6.9.9-25-doc
checking for references to /tmp/nix-build-imagemagick-6.9.9-25.drv-0 in /nix/store/hv2n92d7zd7dkiwwwnffsr08bh0b5syp-imagemagick-6.9.9-25-doc...
/nix/store/pk2laf83fqn40ws8h0zs7amin4r2cnpn-imagemagick-6.9.9-25

@grahamc
Copy link
Member

grahamc commented Dec 5, 2017 •
edited

@GrahamcOfBorg eval

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 8, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

these derivations will be built:
  /nix/store/ljpwlbzhm8cqf75qbcdq0i1amm1ipmvz-ImageMagick-6.9.9-25.tar.xz.drv
  /nix/store/qzhlffv0qwbnz9laf6psjqnid4v244z8-imagemagick-6.9.9-25.drv
building '/nix/store/ljpwlbzhm8cqf75qbcdq0i1amm1ipmvz-ImageMagick-6.9.9-25.tar.xz.drv' on 'ssh://mac1'...
error: build of '/nix/store/ljpwlbzhm8cqf75qbcdq0i1amm1ipmvz-ImageMagick-6.9.9-25.tar.xz.drv' on 'ssh://mac1' failed: builder for '/nix/store/ljpwlbzhm8cqf75qbcdq0i1amm1ipmvz-ImageMagick-6.9.9-25.tar.xz.drv' failed with exit code 1
cannot build derivation '/nix/store/qzhlffv0qwbnz9laf6psjqnid4v244z8-imagemagick-6.9.9-25.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qzhlffv0qwbnz9laf6psjqnid4v244z8-imagemagick-6.9.9-25.drv' failed

@orivej
Copy link
Contributor

orivej commented Dec 8, 2017

New upstream version, source tarball for 6.9.9-23 is no longer available on any of the mirrors

May we just use https://github.com/ImageMagick/ImageMagick?

The current version is 6.9.9-26.

@lheckemann
imagemagick: 6.9.9-23 -> 6.9.9-26
ef66970 
Old source tarball went missing
@lheckemann
Copy link
Member Author

It's almost as if they released -26 as soon as they saw I had opened this PR… :p

I'm not sure if the upstream source tarballs are exactly archives of the repo? My guess is they're not. I'll have a look at converting it though.

@lheckemann lheckemann changed the title imagemagick: 6.9.9-23 -> 6.9.9-25 imagemagick: 6.9.9-23 -> 6.9.9-26 Dec 9, 2017
@lheckemann
Copy link
Member Author

@GrahamcOfBorg build imagemagick

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 9, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/ngrkyqs0j00cd206ss79hnrhbar1h7mh-imagemagick-6.9.9-26-dev/bin/Wand-config: interpreter directive changed from "/bin/sh" to "/nix/store/qwvn7zb0gpwpc2nbap4kvmp3bn243vqv-bash-4.4-p12/bin/sh"
/nix/store/ngrkyqs0j00cd206ss79hnrhbar1h7mh-imagemagick-6.9.9-26-dev/bin/Magick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/qwvn7zb0gpwpc2nbap4kvmp3bn243vqv-bash-4.4-p12/bin/sh"
/nix/store/ngrkyqs0j00cd206ss79hnrhbar1h7mh-imagemagick-6.9.9-26-dev/bin/MagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/qwvn7zb0gpwpc2nbap4kvmp3bn243vqv-bash-4.4-p12/bin/sh"
/nix/store/ngrkyqs0j00cd206ss79hnrhbar1h7mh-imagemagick-6.9.9-26-dev/bin/Magick-config: interpreter directive changed from "/bin/sh" to "/nix/store/qwvn7zb0gpwpc2nbap4kvmp3bn243vqv-bash-4.4-p12/bin/sh"
/nix/store/ngrkyqs0j00cd206ss79hnrhbar1h7mh-imagemagick-6.9.9-26-dev/bin/MagickCore-config: interpreter directive changed from "/bin/sh" to "/nix/store/qwvn7zb0gpwpc2nbap4kvmp3bn243vqv-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-imagemagick-6.9.9-26.drv-0 in /nix/store/ngrkyqs0j00cd206ss79hnrhbar1h7mh-imagemagick-6.9.9-26-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/ydvrgs0hdymyvil654bq9r3hck3bvlxg-imagemagick-6.9.9-26-doc
patching script interpreter paths in /nix/store/ydvrgs0hdymyvil654bq9r3hck3bvlxg-imagemagick-6.9.9-26-doc
checking for references to /tmp/nix-build-imagemagick-6.9.9-26.drv-0 in /nix/store/ydvrgs0hdymyvil654bq9r3hck3bvlxg-imagemagick-6.9.9-26-doc...
/nix/store/1r9pp3d85ykcpqpmkswlyd9370f090b8-imagemagick-6.9.9-26

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 10, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

copying path '/nix/store/bdvlzp5kai64gs4g86am1nz3mwll51rs-openexr-2.2.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/knc0hiahicazwyc30vmacqgydvzzcvym-openjpeg-2.3.0-dev' from 'https://cache.nixos.org'...

trying https://www.imagemagick.org/download/releases/ImageMagick-6.9.9-26.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
copying path '/nix/store/y6qd1vpqp9xnw09g05gdarfy2gc1491x-openexr-2.2.0-dev' from 'https://cache.nixos.org'...
100 8593k  100 8593k    0     0  4296k      0  0:00:02  0:00:02 --:--:-- 3392k
pre-build hook...
error: serialised integer 6999292150276517440 is too large for type 'j'

@lheckemann
Copy link
Member Author

error: serialised integer 6999292150276517440 is too large for type 'j'

what…?

@LnL7
Copy link
Member

LnL7 commented Dec 10, 2017

@lheckemann guess my sandboxing changes don't work yet 😕

@fpletz fpletz merged commit 02c3d34 into NixOS:master Dec 11, 2017
@fpletz
Copy link
Member

fpletz commented Dec 11, 2017

Also updated imagemagick7 and backported to 17.09: 4d0875a...feed006

@lheckemann lheckemann deleted the imagemagick-6.9.9-25 branch December 11, 2017 09:55
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lheckemann @Mic92 @grahamc @orivej @LnL7 @fpletz @GrahamcOfBorg @samueldr