Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefoxPackages: tor-browser: 52.3.0esr-7.0.1 -> 52.5.0esr-7.0-1 #32341

Merged
merged 3 commits into from Dec 5, 2017
Merged

firefoxPackages: tor-browser: 52.3.0esr-7.0.1 -> 52.5.0esr-7.0-1 #32341

merged 3 commits into from Dec 5, 2017

Conversation

oxij
Copy link
Member

@oxij oxij commented Dec 5, 2017

Motivation for this change

Overfermented SLNOS patchset.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from joachifm December 5, 2017 12:34
Mic92
Mic92 reviewed Dec 5, 2017
View reviewed changes
pkgs/applications/networking/browsers/firefox/common.nix
@@ -29,9 +29,11 @@
# Set to `privacySupport` or `false`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation in revert message?

SLNOS added 3 commits December 5, 2017 12:48
@oxij
Revert a part of "firefox: 56.0.2 -> 57.0"
3d8260f 
This reverts a part of commit 559433d.

The problem with removing those options completely is that without them
tor-browser's config differs from the official config (which may or may
not be a problem for fingerprinting).
@oxij
firefoxPackages: move old firefox flags under isTorBrowserLike
d838fbe
@oxij
firefoxPackages: tor-browser: 52.3.0esr-7.0.1 -> 52.5.0esr-7.0-1
d0eed98 
fixes that file:// vuln
@oxij
Copy link
Member Author

oxij commented Dec 5, 2017 via email

@Mic92 Mic92 merged commit d9487e8 into NixOS:master Dec 5, 2017
@Mic92
Copy link
Member

Mic92 commented Dec 6, 2017

also backported.

@oxij oxij deleted the pkg/tor-browser branch March 16, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @Mic92 @GrahamcOfBorg