Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flink: 1.3.2 -> 1.4.0 #33143

Merged
merged 1 commit into from Feb 20, 2018
Merged

flink: 1.3.2 -> 1.4.0 #33143

merged 1 commit into from Feb 20, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Dec 28, 2017 •
edited

Motivation for this change

Upstream release: https://flink.apache.org/news/2017/12/12/release-1.4.0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

@GrahamcOfBorg build flink

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 28, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: while evaluating the attribute 'buildInputs' of the derivation 'flink-1.4.0' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u152b16' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:98:11:
No bootstrap for system

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 28, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/flink-console.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/start-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/config.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/zookeeper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/pyflink.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/start-cluster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/mesos-taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/mesos-taskmanager-flip6.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 28, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/historyserver.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/start-scala-shell.sh: interpreter directive changed from "/bin/bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/flink-console.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/zookeeper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/mesos-appmaster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/start-cluster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0/opt/flink/bin/flink-daemon.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-flink-1.4.0.drv-0 in /nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0...
/nix/store/39sdd2gs36kzi577p52lzbmn7ffcw8ad-flink-1.4.0

@lukateras
Copy link
Member

lukateras commented Dec 28, 2017 •
edited

/nix/store/p3i9axyy2qwhf59v9jscnk760xx3dc0j-flink-1.4.0/opt/flink/bin/flink-console.sh

It should be in /bin, not /opt/flink/bin, fixing just that is OK. Ideally .sh should be additionally stripped, but that may be not as trivial (might require fixing scripts), you might want to try:

for f in $(find . -name \*.sh); do
  mv $f $(dirname $f)/$(basename $f .sh)
done

@mbode
Copy link
Contributor Author

mbode commented Dec 28, 2017

What is the exact convention here, i.e. which of the scripts should be placed in /bin additionally to the main entrypoint flink (which is already there)? I am asking because initially I put all of them there, but this was refactored in dcd9d9f.

@mbode
Copy link
Contributor Author

mbode commented Jan 14, 2018

@yegortimoshenko @orivej Could you give some feedback?

@mbode
Copy link
Contributor Author

mbode commented Jan 28, 2018

@yegortimoshenko @orivej ping

@joachifm
Copy link
Contributor

@GrahamcOfBorg build flink

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m while evaluating the attribute 'buildInputs' of the derivation 'flink-1.4.0' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix�[0m:148:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u172b02' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix�[0m:148:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix�[0m:148:11:
No bootstrap for system

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/start-local.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/start-scala-shell.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/start-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/stop-cluster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/stop-local.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/stop-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/yarn-session.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0/opt/flink/bin/zookeeper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/kj53gymbwizx5gj7xnw7jsmify7dg8h8-flink-1.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/start-local.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/stop-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/pyflink.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/historyserver.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/mesos-appmaster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/stop-cluster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/flink: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0/opt/flink/bin/start-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-flink-1.4.0.drv-0 in /nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0...
/nix/store/dr5aarhs7j8pi0zb05j7m3sj6fjczpds-flink-1.4.0

@joachifm joachifm merged commit af37d08 into NixOS:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mbode @lukateras @joachifm @GrahamcOfBorg