Update supervise, supervise_api #33144
Conversation
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
What is the reason for switching to fetchzip?
There was a problem hiding this comment.
This tarball is not the raw source, it's after running autoreconf to generate ./configure scripts, and creating a tarball with "make distcheck"
There was a problem hiding this comment.
Then you could just add autoreconfHook to the nativeBuildInputs and that would take care of that.
There was a problem hiding this comment.
Yes, I am aware, but this is the official release tarball and it does not need autoreconfHook.
There was a problem hiding this comment.
I'm honestly not sure if we gain anything by running the autoreconfHook against the raw source vs using the release tarball but the recommended way to fetch from github is using fetchFromGitHub rather than fetchurl.
There was a problem hiding this comment.
There's no way to fetch the release tarball using fetchFromGithub. Ignore the fact that the release tarball (which is an opaque artifact which is not automatically derivable from the Git repo) is hosted on Github, the release tarball might as well be from anywhere else.
There was a problem hiding this comment.
@peterhoeg Ping? I really don't think this is a big issue, this is just something that fetchFromGithub is not supposed to do.
If you want I can host the release tarball on my own website so it doesn't say "github" in the URL :)
|
Ping |
|
While this was waiting to merge, I think @FRidh automatically updated pythonPackages.supervise_api, but it has new deps on Python 2 so it's not quite right. But my amended commit fixes it. |
|
@FRidh, any comments on |
|
Definitely not a big deal - thanks for your PR @catern and sorry it took this long. |
No description provided.