Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfig update #33120

Closed
wants to merge 2 commits into from
Closed

Xfig update #33120

wants to merge 2 commits into from

Conversation

jwiegley
Copy link
Contributor

@jwiegley jwiegley commented Dec 27, 2017

Motivation for this change

I found that transfig doesn't build fig2dev on darwin, which is needed to build documentation for coq. This updates to the latest version of xfig, and splits out fig2dev into its own build. Since I'm not entirely sure whether this supplants the earlier build of transfig (especially because there is no longer a transfig binary as a result), I would like solicit comments on this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Could you please split 26cb78b into two commits (one for each package) and rebase on current master?

@jwiegley
Copy link
Contributor Author

@adisbladis Sure.

@jwiegley
Copy link
Contributor Author

@adisbladis Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants