nginx module: only turn on HTTP2 when SSL is enabled #33118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Hrdinka <c.github@hrdinka.at>
|
@hrdinka Thank you very much for finding this. I've spent the last 2 hours trying to find out why the one rarely-used non-SSL default vhost I have returns garbage. The HTTP2 spec supports running without SSL, but apparently nginx's implementation doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#32858 did break all my nginx setups. With that patch "http2" gets appended to all vhosts by default, also to http only port 80 server blocks (like the ones generated by
forceSSL=true). Nginx will then try to communicate securely with clients over port 80 and will return some binary garbage if no TLS certificate was set.The fix is quite simple, it will now only activate HTTP2 when the
sslflag was set as well.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)CC @nh2 @fpletz @globin