Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsyncthingtray: build with native browser to allow for Qt > 5.6 #33128

Merged
merged 1 commit into from Feb 11, 2018
Merged

qsyncthingtray: build with native browser to allow for Qt > 5.6 #33128

merged 1 commit into from Feb 11, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

This means we can drop the Qt 5.6 dependency. I've been running with it here for some time without problems.

Cc: @zraexy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

adisbladis commented Dec 29, 2017 •
edited

@peterhoeg Is there a reason why you would want to build against Qt 5.6? I would like it if we could drop the Qt 5.6 dependency altogether.

@peterhoeg
Copy link
Member Author

This PR removes functionality so if someone desperately needs the built-in browser, they can build it against 5.6.

@adisbladis adisbladis mentioned this pull request Jan 12, 2018
Closed
25 tasks
@peterhoeg peterhoeg requested a review from FRidh January 13, 2018 06:11
@FRidh FRidh removed their request for review February 11, 2018 08:38
@FRidh FRidh merged commit d8b8c6b into NixOS:master Feb 11, 2018
@peterhoeg peterhoeg deleted the u/qst branch February 11, 2018 12:04
@peterhoeg peterhoeg restored the u/qst branch February 12, 2018 12:30
@peterhoeg peterhoeg deleted the u/qst branch March 5, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @adisbladis @FRidh @GrahamcOfBorg