ghc: wire up new binary ghc for bootstrapping #33129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed in e7fee0e327afc61edb0a9f086baa4f1528af174c; test builds are running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. |
Ericson2314
approved these changes
Dec 28, 2017
| inherit (bootPkgs) alex happy; | ||
| inherit buildPlatform targetPlatform; | ||
| selfPkgs = packages.ghcHEAD; | ||
| }; | ||
| ghcjs = packages.ghc7103.callPackage ../development/compilers/ghcjs { | ||
| bootPkgs = packages.ghc7103; | ||
| bootPkgs = packages.ghc821Binary; |
There was a problem hiding this comment.
IIRC GHCJS needs older but I forget
There was a problem hiding this comment.
I haven't bothered since it's broken before this PR.
| @@ -6,6 +6,9 @@ let | |||
| "ghc6102Binary" | |||
| "ghc704Binary" | |||
| "ghc742Binary" | |||
| "ghc784Binary" | |||
There was a problem hiding this comment.
This mean we can get rid of those ignored integer simple flags?
This change brings development feedback loop improvement from a couple of ghc rebuilds to only one for working on generic builder. To completely eliminate the rebuilds, use two nixpkgs clones and point boot packages to the unmodified one.
domenkozar
force-pushed
the
ghc-binary-boot-pkgs
branch
from
32f96e1
to
695a026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings development feedback loop improvement
from a couple of ghc rebuilds to only one for working on generic
builder.
To completely eliminate the rebuilds, use two nixpkgs clones
and point boot packages to the unmodified one.
Fixes #19926
Tested only on linux, I've found no regressions.