added 'An Anarchist FAQ' (AFAQ) package. #33141

oida · 2017-12-28T17:38:45Z

Motivation for this change

Anarchy!

Things done

[x ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- [x ] NixOS
- macOS
- other Linux distributions
[x ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x ] Tested execution of all binary files (usually in ./result/bin/)
[x ] Fits CONTRIBUTING.md.

catern · 2017-12-28T18:11:41Z

pkgs/top-level/all-packages.nix

@@ -1216,7 +1216,7 @@ with pkgs;
  mpdris2 = callPackage ../tools/audio/mpdris2 { };

  nfdump = callPackage ../tools/networking/nfdump { };
-


Unneeded whitespace damage?

lukateras

Heh :-) Seriously, though, should we package political books in Nixpkgs? I'd rather not do that.

lukateras · 2017-12-28T18:24:11Z

pkgs/misc/anarchism/default.nix

+    mkdir -p $out/share/applications/
+    cp -r html $out/share/doc/anarchism/
+    cp -r markdown $out/share/doc/anarchism/
+    echo \[Desktop Entry\] > $out/share/applications/anarchism.desktop


Use makeDesktopItem. Here are examples: https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=makeDesktopItem&type=

Did it, had to change the name tho as that fails with spaces, don't like it. :(

lukateras · 2017-12-28T18:25:44Z

pkgs/misc/anarchism/default.nix

+  };
+
+  installPhase = ''
+    mkdir -p $out/share/doc/anarchism/html


Is this really documentation, though?

lukateras · 2017-12-28T18:27:00Z

pkgs/misc/anarchism/default.nix

+    mkdir $out/share/doc/anarchism/markdown
+    mkdir -p $out/share/applications/
+    cp -r html $out/share/doc/anarchism/
+    cp -r markdown $out/share/doc/anarchism/


Better just mv, that would make it clearer:

mkdir -p $out/share/doc/anarchism mv html markdown $out/share/doc/anarchism

lukateras · 2017-12-28T18:27:45Z

pkgs/misc/anarchism/default.nix

+  name = "anarchism-${version}";
+  version = "15.0";
+  src = fetchurl {
+    url = https://0xacab.org/ju/afaq/repository/master/archive.tar.gz;


This will break very soon. You should provide a link to a stable archive, i.e. one that will never change. Or use fetchgit.

lukateras · 2017-12-28T18:33:48Z

pkgs/misc/anarchism/default.nix

+{ stdenv, fetchurl }:
+
+stdenv.mkDerivation rec {
+  name = "anarchism-${version}";


anarchism is not a proper name for this work. It could be afaq, for example.

It has been for many years in debian world, on archlinux and whatnot. It's a well known package and often refered to by it's pkg name and I'd like to keep it that way.

Context: https://lists.debian.org/debian-devel/1999/03/msg01628.html

Including this package in Debian has been a mistake that I would not like to see repeated here. Software distributions are not a proper place for political debate: accepting this package would set a precedent to accept other similar packages, including those that manifest political viewpoints from the opposite side of the spectrum.

lukateras · 2017-12-28T18:37:18Z

Sorry, I don't think this is a good idea.

lukateras · 2017-12-28T18:40:43Z

pkgs/misc/anarchism/default.nix

+      politics, social organization, and economics.
+    '';
+    homepage = http://www.anarchistfaq.org;
+    license = stdenv.lib.licenses.gpl2;


It's actually under GNU FDL, see: https://en.wikipedia.org/wiki/An_Anarchist_FAQ

Both can be applied: "Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.1 or any later version published by the Free Software Foundation, and/or the terms of the GNU General Public License, Version 2.0 or any later version published by the Free Software Foundation." http://www.anarchism.pageabode.com/afaq/intro.html

fpletz · 2017-12-29T11:22:50Z

@yegortimoshenko Closing this PR and limiting the conversion to collaborators without any discussion only based on your opinion is ridiculous. You're not not speaking for the whole project and please do not try to do so.

fpletz · 2017-12-29T11:23:47Z

As I somehow cannot unlock this PR: @oida please open a new PR if you still intend to include the package.

gebner · 2017-12-29T11:37:57Z

Interestingly, I was able to unlock it.

I'm not sure if this package fits into scope of nixpkgs, though. We don't package offline builds of wikipedia either.

vcunat · 2017-12-29T13:13:16Z

IMO packaging political books serves little purpose except as "publicity" for the programme (books tend to be easy to "just download"). I'd prefer to avoid spending energy on politics around nixos.org, as I can't see any sufficient relation.

lukateras · 2017-12-29T15:29:51Z

Closing this PR and limiting the conversion to collaborators without any discussion only based on your opinion is ridiculous.

I don't think so. I've closed this because I feel confident about my decision and I don't believe this to be worth time of other members. Nod from @grahamc seems to be enough.

Limiting conversation to collaborators is exactly that, i.e. you can still respond. I've locked it because I don't want this to turn into a political debate (there are no practical questions left unasked), and I ask you to lock it again.

Any political books (and discussions) are divisive by their nature, as in, they tend to impose enemies on readers and divide the world into "us" and "them". I think everyone would agree, no matter what their particular political views are, that software distribution is not a proper place for that, and if anything, it would result in a less welcoming and more divisive community for everyone involved.

Also, I'm not convinced that packaging any book is practical at all. Tarballs are a better way to store data than in Nixpkgs, because tarballs don't have a build program attached to them, they are purely declarative.

lukateras · 2017-12-29T16:39:35Z

Also, nowhere have I implied that I speak for the whole project. Not sure what makes you think that.

catern · 2017-12-29T17:45:01Z

Using Nix to package/distribute books and non-technical documents could be interesting. If someone wants to experiment with it, they should do it in a separate repository of "Nixbooks" (possibly as a Nixpkgs overlay), and if it proves itself as useful, it could be merged into Nixpkgs. I think @oida should do that if they want to continue with this derivation.

The fact that this is a political work is a distraction; even if it wasn't political, it wouldn't make sense to merge, because it's not clear that it makes sense to distribute books through Nix at all. And if it turns out to make sense to distribute books through Nix, then the political content of the books would be irrelevant.

lukateras · 2017-12-29T18:47:06Z

And if it turns out to make sense to distribute books through Nix, then the political content of the books would be irrelevant.

That would only be true if genuinely no particular criteria were applied to accepting books other than willingness of someone to maintain them. It seems highly improbable to me that that would actually be the case, while distributed systems like Web or IPFS solve this problem by not relying on any single authority for making data publicly accessible.

Distributed systems also work around censorship issue, where some books are acceptable in some jurisdictions but are banned in others.

In other words, hypothetical Nixbooks would never work for political material.

Software for the most part doesn't pose ethical/moral issues in itself and is only concerned about practicality. Games, movies and fiction all also have a practical purpose, that of enjoyment. Political material is inherently different because it incentivizes action in the real world, and divides people into friends and enemies, the latter being more pronounced in radical books like one in this pull request.

Also please note that maintaining something in software distribution has a lot of overhead, because, unlike in Web or IPFS, accepting something requires some top-down effort and that doesn't scale well. Coping with this overhead only makes sense when it has practical advantages.

added 'An Anarchist FAQ' (AFAQ) package.

7bb6261

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 28, 2017

catern reviewed Dec 28, 2017

View reviewed changes

lukateras requested changes Dec 28, 2017

View reviewed changes

lukateras reviewed Dec 28, 2017

View reviewed changes

lukateras closed this Dec 28, 2017

lukateras reviewed Dec 28, 2017

View reviewed changes

NixOS locked as too heated and limited conversation to collaborators Dec 28, 2017

NixOS unlocked this conversation Dec 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added 'An Anarchist FAQ' (AFAQ) package. #33141

added 'An Anarchist FAQ' (AFAQ) package. #33141

oida commented Dec 28, 2017

catern Dec 28, 2017

lukateras left a comment

lukateras Dec 28, 2017

oida Dec 28, 2017

lukateras Dec 28, 2017

oida Dec 28, 2017

lukateras Dec 28, 2017

oida Dec 28, 2017

lukateras Dec 28, 2017

oida Dec 28, 2017

lukateras Dec 28, 2017 •

edited

oida Dec 28, 2017

lukateras Dec 28, 2017 •

edited

lukateras commented Dec 28, 2017

lukateras Dec 28, 2017 •

edited

oida Dec 28, 2017

fpletz commented Dec 29, 2017

fpletz commented Dec 29, 2017

gebner commented Dec 29, 2017

vcunat commented Dec 29, 2017

lukateras commented Dec 29, 2017 •

edited

lukateras commented Dec 29, 2017 •

edited

catern commented Dec 29, 2017

lukateras commented Dec 29, 2017 •

edited

		@@ -1216,7 +1216,7 @@ with pkgs;
		mpdris2 = callPackage ../tools/audio/mpdris2 { };

		nfdump = callPackage ../tools/networking/nfdump { };

added 'An Anarchist FAQ' (AFAQ) package. #33141

added 'An Anarchist FAQ' (AFAQ) package. #33141

Conversation

oida commented Dec 28, 2017

Motivation for this change

Things done

Choose a reason for hiding this comment

lukateras left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukateras Dec 28, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukateras Dec 28, 2017 • edited

Choose a reason for hiding this comment

lukateras commented Dec 28, 2017

lukateras Dec 28, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpletz commented Dec 29, 2017

fpletz commented Dec 29, 2017

gebner commented Dec 29, 2017

vcunat commented Dec 29, 2017

lukateras commented Dec 29, 2017 • edited

lukateras commented Dec 29, 2017 • edited

catern commented Dec 29, 2017

lukateras commented Dec 29, 2017 • edited

lukateras Dec 28, 2017 •

edited

lukateras Dec 28, 2017 •

edited

lukateras Dec 28, 2017 •

edited

lukateras commented Dec 29, 2017 •

edited

lukateras commented Dec 29, 2017 •

edited

lukateras commented Dec 29, 2017 •

edited