Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yle-dl: 2.28 -> 2.30 #33136

Merged
merged 1 commit into from Dec 28, 2017
Merged

yle-dl: 2.28 -> 2.30 #33136

merged 1 commit into from Dec 28, 2017

Conversation

jluttine
Copy link
Member

Motivation for this change

Update yle-dl and add some missing dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Dec 28, 2017

@GrahamcOfBorg build yle-dl

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘yle-dl-2.30’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/tools/misc/yle-dl/default.nix:21 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux


----------------------------------------------------------------------
Ran 801 tests in 0.487s

FAILED (failures=2, errors=1, skipped=165)
Test failed: <unittest.runner.TextTestResult run=801 errors=1 failures=2>
error: Test failed: <unittest.runner.TextTestResult run=801 errors=1 failures=2>
builder for '/nix/store/6ilhv52h2fk12ad9zsr1fiab46irqzss-python2.7-PyAMF-0.8.0.drv' failed with exit code 1
cannot build derivation '/nix/store/s1miiwh8xjmrnkkrasqdkzrn2m3vgc5g-yle-dl-2.30.drv': 1 dependencies couldn't be built
error: build of '/nix/store/s1miiwh8xjmrnkkrasqdkzrn2m3vgc5g-yle-dl-2.30.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Installing collected packages: yle-dl
Successfully installed yle-dl-2.30
/tmp/nix-build-yle-dl-2.30.drv-0/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30
stripping (with flags -S) in /nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30/lib  /nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30/bin 
patching script interpreter paths in /nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30
checking for references to /tmp/nix-build-yle-dl-2.30.drv-0 in /nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30...
wrapping `/nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30/bin/yle-dl'...
/nix/store/1ymfv4p68yypdzqd9a9ilcy8807fawfs-yle-dl-2.30

@globin globin merged commit f297764 into NixOS:master Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants