Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticsearch-curator: init at 5.4.1 #32905

Merged
merged 4 commits into from
Dec 21, 2017
Merged

elasticsearch-curator: init at 5.4.1 #32905

merged 4 commits into from
Dec 21, 2017
+94 −25

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Dec 20, 2017 •
edited
Loading

Motivation for this change

This is a handy tool for tending your Elasticsearch indices.

See: https://github.com/elastic/curator

Things done

For meeting dependencies I added the voluptuous Python library and upgraded the elasticsearch Python library from 1.9.0 to 6.0.0.

I tested this by running:

curator_cli --host my-elasticsearch-host show_indices

and observing the expected list of indici.

Note that this is both a Python library as well as a Python CLI script.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@basvandijk basvandijk requested a review from FRidh as a code owner December 20, 2017 16:55
@orivej
Copy link
Contributor

orivej commented Dec 21, 2017 •
edited
Loading

Could you split the changes to different packages into different commits, delete pyelasticsearch because it requires ancient version of elasticsearch which may not be compatible with any existing installations, and add missing nosexcover (and possibly other) check input(s) to elasticsearch-curator?

@basvandijk basvandijk force-pushed the elasticsearch-curator-5.4.1 branch from 79ff624 to 761d01e Compare December 21, 2017 21:10
@basvandijk
Copy link
Member Author

@orivej thank you for reviewing this! I made your suggested changes. The package now builds with --option build-use-sandbox true.

basvandijk and others added 4 commits December 21, 2017 23:36
@basvandijk @orivej
python.pkgs.voluptuous: init at 0.10.5
b513fc7 
Needed by elasticsearch-curator.
@orivej
python.pkgs.pyelasticsearch: delete
f0c4bea 
because it requires python.pkgs.elasticsearch 1.x.y, which is compatible only
with the ancient Elasticsearch 1.
@basvandijk @orivej
python.pkgs.elasticsearch: 1.9.0 -> 6.0.0
d513afc
@basvandijk @orivej
python.pkgs.elasticsearch-curator: init at 5.4.1
85ee9df
@orivej orivej force-pushed the elasticsearch-curator-5.4.1 branch from 761d01e to 85ee9df Compare December 21, 2017 23:46
@orivej orivej merged commit fa2f609 into NixOS:master Dec 21, 2017
@orivej
Copy link
Contributor

orivej commented Dec 21, 2017

Thanks!

@basvandijk basvandijk mentioned this pull request Jan 12, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @orivej @GrahamcOfBorg