Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbitcoin-protocol: init at 3.4.0 #32906

Closed
wants to merge 1 commit into from
Closed

libbitcoin-protocol: init at 3.4.0 #32906

wants to merge 1 commit into from

Conversation

asymmetric
Copy link
Contributor

Motivation for this change

Required by libbitcoin-client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

orivej
orivej suggested changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is generally better to add libraries together with the programs that use them (in the same PR in different commits) because the build of the programs confirms that the libraries are packaged as needed.

pkgs/tools/misc/libbitcoin/libbitcoin-protocol.nix
name = "${pname}-${version}";

src = fetchurl {
url = "https://github.com/libbitcoin/${pname}/archive/v${version}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use fetchurl with GitHub archives: NixOS/nix#1735 (comment)

@asymmetric asymmetric closed this Dec 20, 2017
@asymmetric asymmetric deleted the asymmetric/libbitcoin-protocol branch December 20, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asymmetric @orivej @GrahamcOfBorg