Tempfile: Add Tempfile.tempname
#5360
Merged
+33
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method behaves similarly to the
Dir::Tempname.make_tmpname
method in Ruby in that it creates a filename that is not likely
to currently exist on disk.
Some key differences:
tempname
is fully qualified with the value ofTempfile.dirname
,while
make_tmpname
was not fully qualified by default.tempname
does not allow the user to specify a custom prefix.tempname
does not allow the user to specify a custom trailingidentifier.
Like
make_tmpname
in Ruby, this implementation is susceptible to TOCTOU, and does not actually test for the file's existence beforehand -- it counts on the space ofRandom.rand(0x100000000).to_s(36)
being large enough for most purposes.I'm just learning Crystal, so please let me know if there's anything I can do to improve this PR!