Skip to content

Commit

Permalink
Fixes another regression from fix of #4882. In this case we would loo…
Browse files Browse the repository at this point in the history
…k for

duplicated variables in higher level production f_opt and f_block_opt but now
that check is done at the actual variable itself.
enebo committed Dec 6, 2017
1 parent 2eafcdb commit 5dc99c3
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 2 additions & 4 deletions core/src/main/java/org/jruby/ext/ripper/RipperParser.java
Original file line number Diff line number Diff line change
@@ -4608,7 +4608,6 @@ public Object yyparse (RipperLexer yyLex) throws java.io.IOException {
states[591] = new RipperParserState() {
@Override public Object execute(RipperParser p, Object yyVal, Object[] yyVals, int yyTop) {
p.setCurrentArg(null);
p.arg_var(p.formal_argument(((IRubyObject)yyVals[-2+yyTop])));
yyVal = p.new_assoc(p.assignable(((IRubyObject)yyVals[-2+yyTop])), ((IRubyObject)yyVals[0+yyTop]));

return yyVal;
@@ -4617,7 +4616,6 @@ public Object yyparse (RipperLexer yyLex) throws java.io.IOException {
states[592] = new RipperParserState() {
@Override public Object execute(RipperParser p, Object yyVal, Object[] yyVals, int yyTop) {
p.setCurrentArg(null);
p.arg_var(p.formal_argument(((IRubyObject)yyVals[-2+yyTop])));
yyVal = p.new_assoc(p.assignable(((IRubyObject)yyVals[-2+yyTop])), ((IRubyObject)yyVals[0+yyTop]));
return yyVal;
}
@@ -4799,6 +4797,6 @@ public Object yyparse (RipperLexer yyLex) throws java.io.IOException {
}
};
}
// line 2155 "RipperParser.y"
// line 2153 "RipperParser.y"
}
// line 9486 "-"
// line 9484 "-"
2 changes: 0 additions & 2 deletions core/src/main/java/org/jruby/ext/ripper/RipperParser.y
Original file line number Diff line number Diff line change
@@ -2012,14 +2012,12 @@ f_kwrest : kwrest_mark tIDENTIFIER {

f_opt : f_arg_asgn '=' arg_value {
p.setCurrentArg(null);
p.arg_var(p.formal_argument($1));
$$ = p.new_assoc(p.assignable($1), $3);

}

f_block_opt : f_arg_asgn '=' primary_value {
p.setCurrentArg(null);
p.arg_var(p.formal_argument($1));
$$ = p.new_assoc(p.assignable($1), $3);
}

0 comments on commit 5dc99c3

Please sign in to comment.