Fix some build warnings caused by unused variables/unnecessary tests #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
requested changes
Dec 11, 2017
| @@ -40,7 +40,6 @@ void test_when_each_from_list() | |||
|
|
|||
| unsigned id = fut.get(); | |||
|
|
|||
| HPX_TEST(id >= 0); | |||
There was a problem hiding this comment.
this should rather be HPX_TEST(id > 0), shouldn't it?
There was a problem hiding this comment.
If I understand the test correctly, no. At least id will be 0 the for the first future processed by when_each a bit further down. The important test is HPX_TEST_EQ(id, idx).
| @@ -52,7 +51,6 @@ void test_when_each_from_list() | |||
| unsigned id = fut.get(); | |||
|
|
|||
| HPX_TEST_EQ(idx, id); | |||
| HPX_TEST(id >= 0); | |||
| @@ -101,7 +99,6 @@ void test_when_each_from_list_iterators() | |||
|
|
|||
| unsigned id = fut.get(); | |||
|
|
|||
| HPX_TEST(id >= 0); | |||
sithhell
approved these changes
Dec 12, 2017
| @@ -40,7 +40,6 @@ void test_when_each_from_list() | |||
|
|
|||
| unsigned id = fut.get(); | |||
|
|
|||
| HPX_TEST(id >= 0); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.