Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocamlnet: 4.1.4 -> 4.1.5 #32400

Merged
merged 2 commits into from Dec 8, 2017
Merged

ocamlPackages.ocamlnet: 4.1.4 -> 4.1.5 #32400

merged 2 commits into from Dec 8, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Dec 7, 2017

cc/ @vcunat who added temporary nettle_3_3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Dec 8, 2017

👍 for removing nettle_3_3 (I'm no good with ocaml).

@pSub pSub merged commit b00f806 into NixOS:master Dec 8, 2017
@vbgl vbgl deleted the ocamlnet-4.1.5 branch December 8, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @vcunat @pSub @GrahamcOfBorg