Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualboxHeadless: fix build, cleanup buildInputs #32394

Merged
merged 2 commits into from Dec 9, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 7, 2017

Motivation for this change

This fixes #32199.

In addition, this moves some native build inputs from buildInputs to nativeBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

…_NOREF

Signed-off-by: Florian Klink <flokli@flokli.de>
These threw warnings when building man pages.

Also move some buildInputs to nativeBuildInputs.
@Mic92 Mic92 merged commit 379907c into NixOS:master Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

virtualbox headless fails to build in unstable
3 participants