nixos/programs/bash: Let bash-completion lazy load scripts #32534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in detail here: NixOS#32533 bash will load completion scripts in $p/share/bash-completion/completions/ on startup instead of letting bash-completion do it's lazy loading. Bash startup will then slow down (very noticeable when bash-completion is installed in a profile). This commit leaves loading of scripts in the hands of bash-completion, improving startup time for everyone using `enableCompletion`. fixes NixOS#32533
8 tasks
orivej
approved these changes
Dec 10, 2017
|
Right, so the whole loop over |
|
I don't think the loop can be removed because this will disable obsolete completions installed into the user profile. (The system profile completions will be loaded from |
|
Ah, yeah, true. |
|
Thank you! |
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in detail here: #32533
bash will load completion scripts in
<nix-profiles>/share/bash-completion/completions/onstartup instead of letting bash-completion do it's lazy loading. Bash startup
will then slow down (very noticeable when bash-completion is installed in a
profile, see #22648).
Motivation for this change
This commit leaves loading of scripts in the hands of bash-completion,
improving startup time for everyone using
enableCompletion.Things done
I've tested the changes making sure that completion scrips in
/run/current-system/sw/share/bash-completion/completionsand~/.nix-profile/share/bash-completion/completionsis working correctly.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)