Fix for builds with system libcurl < 7.30 #1722
Conversation
CentOS 7.4 and RHEL 7.4 ship with libcurl-devel-7.29.0-42.el7.x86_64; this flag was added in 7.30.0 https://curl.haxx.se/libcurl/c/CURLMOPT_MAX_TOTAL_CONNECTIONS.html
| @@ -369,11 +369,13 @@ struct CurlDownloader : public Downloader | |||
|
|
|||
| curlm = curl_multi_init(); | |||
|
|
|||
| #if LIBCURL_VERSION_NUM >= 0x072b00 // correct? | |||
There was a problem hiding this comment.
The answer to your question is that it was indeed correct, @edolstra :)
https://curl.haxx.se/libcurl/c/CURLMOPT_PIPELINING.html
I can remove/reformat/change the comments if you prefer.
|
Disabling multiplexing will kill HTTP/2 performance. But then, maybe those curl versions don't support HTTP/2 anyway? |
|
Indeed, if you have an older libcurl the choices are either fail to compile or build without HTTP/2; the libcurl used on CentOS/RHEL came out in early 2013. Probably the best thing to do is use an existing nix installation to bootstrap a statically linked nix for deployment. I believe @abbradar mentioned doing something to this effect for CentOS 7.4, but that said, it doesn't hurt to have the option of building Nix by itself on these platforms. |
CentOS 7.4 and RHEL 7.4 ship with
libcurl-devel-7.29.0-42.el7.x86_64; this flagwas added in 7.30.0
https://curl.haxx.se/libcurl/c/CURLMOPT_MAX_TOTAL_CONNECTIONS.html
Tangentially related to NixOS/nixpkgs#32320, which tracks some efforts to get the latest Nix working on CentOS 7.4. To fully get there we need to figure out what to do with c++14 and libsodium, but in the meantime this is a generic fix for any enterprise distribution maintaining an older libcurl for binary compatibility.