networkmanager: remove restart after suspend from resume #32529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit ec9dc73 restarting NetworkManager after resume from suspend/hibernate was introduced. When I initially switch to NixOS I started noticing a high delay between wakeup and re-connecting to WiFi & wired networks. The delay increased from a few seconds (on my previous distro, same software stack) to almost half a minute with NixOS. I (locally) applied the change in this commit a few weeks ago and tested since then. The notebook/mobile device experience has improved a lot. Reconnects are as before switching to NixOS. Issue NixOS#24401 could be related to this. Since I am not using KDE/plasma5 I can only guess…
orivej
approved these changes
Dec 9, 2017
|
This is similar to #30124. |
|
@domenkozar |
|
@danbst upon resuming suspend, although connection as supposed to be established according to nm, packets were getting through. |
|
I have experienced such issues with NetworkManager before this PR was merged, but they were expected: I was resuming in a totally different place that had a synonymous WiFi network. (And I did not experience the delays @andir has described, so I was not even aware that NetworkManager was restarting.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In commit ec9dc73 restarting NetworkManager after resume from
suspend/hibernate was introduced.
When I initially switch to NixOS I started noticing a high delay between
wakeup and re-connecting to WiFi & wired networks. The delay increased
from a few seconds (on my previous distro, same software stack) to
almost half a minute with NixOS.
I (locally) applied the change in this commit a few weeks ago and tested
since then. The notebook/mobile device experience has improved a lot.
Reconnects are as before switching to NixOS.
Issue #24401 could be related to this. Since I am not using KDE/plasma5
I can only guess…
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)