Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmime: 3.0.1 -> 3.0.5 #32520

Merged
merged 1 commit into from Dec 9, 2017
Merged

gmime: 3.0.1 -> 3.0.5 #32520

merged 1 commit into from Dec 9, 2017

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Dec 9, 2017

Motivation for this change

Update to latest upstream version (needed by notmuch)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej merged commit 5da9f61 into NixOS:master Dec 9, 2017
@vcunat
Copy link
Member

vcunat commented Dec 10, 2017 •
edited

This commit broke notmuch tests on Hydra: https://hydra.nixos.org/build/65738673
EDIT: you're motivated by notmuch, and that makes it all even more suspicious.

@vcunat
Copy link
Member

vcunat commented Dec 10, 2017

/cc notmuch maintainers: @chaoflow, @garbas.

@orivej
Copy link
Contributor

orivej commented Dec 10, 2017

@KaiHa you should have updated gmime3 and notmuch in the same PR.

notmuch 0.25.3 NEWS says:

Correctly report userid validity. Fix test suite failure for GMime >= 3.0.3. This change raises the minimum supported version of GMime 3.x to 3.0.3.

@orivej
Copy link
Contributor

orivej commented Dec 10, 2017

notmuch 0.25.3 tests do not pass with this version of gmime, so I have reverted it back to 3.0.1 in b6bf8db.

@KaiHa
Copy link
Contributor Author

KaiHa commented Dec 10, 2017

@orivej the test is even with Notmuch 0.25.3 failing [1]. But yes, I should have checked if I would break the existing Notmuch version.

[1] https://notmuchmail.org/pipermail/notmuch/2017/025956.html

@orivej
Copy link
Contributor

orivej commented Dec 10, 2017 •
edited

@the-kenny has fixed notmuch tests and updated gmime3 and notmuch in 7df7739 and 8974a9b.

orivej referenced this pull request Dec 10, 2017
@orivej
Revert "gmime: 3.0.1 -> 3.0.5"
b6bf8db 
It breaks notmuch 0.25.2 tests, and updating notmuch to 0.25.3 does not fix them.
@KaiHa KaiHa deleted the gmime-3.0.5 branch December 10, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KaiHa @vcunat @orivej @GrahamcOfBorg