Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udiskie: 1.7.2 -> 1.7.3 #33206

Merged
merged 1 commit into from Dec 31, 2017
Merged

udiskie: 1.7.2 -> 1.7.3 #33206

merged 1 commit into from Dec 31, 2017

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc maintainer @AndersonTorres

@dotlambda
Copy link
Member Author

I also propose to migrate udiskie to python3 because py2 is deprecated since version 1.7.2.

@dotlambda
Copy link
Member Author

/cc @vyp

@adisbladis adisbladis merged commit 0f74917 into NixOS:master Dec 31, 2017
@adisbladis
Copy link
Member

I changed it to python 3 in f772b8d

Works nicely. Thanks!

@dotlambda dotlambda deleted the udiskie branch December 31, 2017 08:35
@mdorman
Copy link
Contributor

mdorman commented Dec 31, 2017

Attempting to build this fails for me:

installing
/tmp/nix-build-udiskie-1.7.3.drv-0/source/dist /tmp/nix-build-udiskie-1.7.3.drv-0/source
Processing ./udiskie-1.7.3-py2-none-any.whl
Collecting PyYAML (from udiskie==1.7.3)
  Could not find a version that satisfies the requirement PyYAML (from udiskie==1.7.3) (from versions: )
No matching distribution found for PyYAML (from udiskie==1.7.3)

@adisbladis
Copy link
Member

@mdorman Sorry.. My bad. Fixed in afab19e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @adisbladis @mdorman @GrahamcOfBorg