Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamsmtp package and module #33230

Closed
wants to merge 4 commits into from
Closed

Clamsmtp package and module #33230

wants to merge 4 commits into from

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Dec 31, 2017

Motivation for this change

Add a package and a module for clamsmtp.

Note this combo's quite well with #33228 (and is actually the reason for my adding the PrivateTmp workaround)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ekleog
Copy link
Member Author

Ekleog commented Dec 31, 2017

Hmm, doesn't work any better with an additional PrivateTmp as per last push -f :/ (also, I can't just add in PrivateNetwork, as clamsmtp is indeed supposed to listen on a port on localhost)

@joachifm
Copy link
Contributor

Vexing. Is clamsmtp always started after the clamav daemon? That's the only other thing I can think of :( Regrettably, I have little practical experience with namespace joining, only what I've read, so take my comments with a helping of salt.

@Ekleog
Copy link
Member Author

Ekleog commented Jan 1, 2018

Shame on me. Somehow when testing I didn't notice this...

Now it looks like clamsmtp works with clamdscan and without PrivateTmp, meaning #33228 is no longer required for this module to work to full capacity.

Thanks! :)

@joachifm
Copy link
Contributor

joachifm commented Jan 6, 2018

Resolved conflicts & merged at cb506e6. Thank you

@joachifm joachifm closed this Jan 6, 2018
@Ekleog Ekleog deleted the clamsmtp branch January 6, 2018 18:45
@Ekleog
Copy link
Member Author

Ekleog commented Jan 6, 2018

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @joachifm @GrahamcOfBorg