Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitlbee-discord: init at 2017-12-27 #33212

Merged
merged 1 commit into from Jan 12, 2018
Merged

Conversation

Lassulus
Copy link
Member

No description provided.

};

nativeBuildInputs = [ pkgconfig ];
buildInputs = [ bitlbee autoconf automake libtool glib ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect autoconf, automake, and libtool can be treated as native inputs as well. You can also try replacing them with autoreconfHook, it adds those things & does autogen and whatnot.

Copy link
Contributor

@joachifm joachifm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added two minor nits

@@ -0,0 +1,29 @@
{ fetchurl, fetchFromGitHub, stdenv, bitlbee, autoreconfHook, pkgconfig, glib }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchurl is unused

./autogen.sh
'';

meta = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding yourself as the maintainer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Lassulus
Copy link
Member Author

@joachifm ping?

@Mic92 Mic92 merged commit 9703188 into NixOS:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants