New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitlbee-discord: init at 2017-12-27 #33212
Conversation
}; | ||
|
||
nativeBuildInputs = [ pkgconfig ]; | ||
buildInputs = [ bitlbee autoconf automake libtool glib ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect autoconf, automake, and libtool can be treated as native inputs as well. You can also try replacing them with autoreconfHook
, it adds those things & does autogen and whatnot.
190b14d
to
fffca34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added two minor nits
@@ -0,0 +1,29 @@ | |||
{ fetchurl, fetchFromGitHub, stdenv, bitlbee, autoreconfHook, pkgconfig, glib }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchurl
is unused
./autogen.sh | ||
''; | ||
|
||
meta = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding yourself as the maintainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
fffca34
to
b5cdcd6
Compare
b5cdcd6
to
6ae7004
Compare
@joachifm ping? |
No description provided.