Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxc: init at 2.2.3 #33232

Merged
merged 1 commit into from Dec 31, 2017
Merged

libxc: init at 2.2.3 #33232

merged 1 commit into from Dec 31, 2017

Conversation

markuskowa
Copy link
Member

Motivation for this change

Libxc is a library with density functionals used by quantum chemistry programs
(e.g. octopus, PR will follow).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej force-pushed the libxc-pr branch 3 times, most recently from 549cfe8 to 7be830a Compare December 31, 2017 05:33
@orivej
Copy link
Contributor

orivej commented Dec 31, 2017

meta.description should not have a period at the end.

Please configure your editor to delete whitespace at the ends of the lines.

I have fixed this and switched to building a shared library.

Is it important to package the older version 2.2.3 when the current is 4.0.3?

@orivej
Copy link
Contributor

orivej commented Dec 31, 2017

I have fixed the license: it is LGPL 3, not GPL 3.

@markuskowa
Copy link
Member Author

Sorry for the merge confusion.

@orivej
Copy link
Contributor

orivej commented Dec 31, 2017

I'll clean it up. So, is it important to package the older version 2.2.3 when the current is 4.0.3?

@markuskowa
Copy link
Member Author

They have three active packages out there at moment. The manual of octopus recommends 2.2.3 at the moment. I'll go with 2.2.3 as stable version for now.

@orivej orivej merged commit 5be70c3 into NixOS:master Dec 31, 2017
@markuskowa markuskowa deleted the libxc-pr branch January 19, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @orivej