Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl8812au: fix build #33209

Merged
merged 1 commit into from Dec 31, 2017
Merged

rtl8812au: fix build #33209

merged 1 commit into from Dec 31, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

Failure to build. Please also backport to 17.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member

pbogdan commented Dec 30, 2017

Discussion in #33166 may be relevant.

@orivej orivej merged commit a341448 into NixOS:master Dec 31, 2017
@orivej
Copy link
Contributor

orivej commented Dec 31, 2017

Fixed using #33166.

@orivej
Copy link
Contributor

orivej commented Dec 31, 2017

Released in 01f8250

@orivej orivej added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 31, 2017
@lheckemann lheckemann deleted the rtl8812au-fix branch December 31, 2017 10:43
@lheckemann
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lheckemann @pbogdan @orivej @GrahamcOfBorg