Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc-kde-theme: init 2017-11-09 #33208

Merged
merged 1 commit into from Jan 10, 2018
Merged

arc-kde-theme: init 2017-11-09 #33208

merged 1 commit into from Jan 10, 2018

Conversation

nixy
Copy link
Contributor

@nixy nixy commented Dec 30, 2017

Motivation for this change

I was looking to add some QT themes besides breeze to KDE. I looked through nixpkgs and couldn't find any other themes to base this off of. I've tested this and it seems to work, but if there is any way to make it better let me know.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Dec 31, 2017
Closed
3 tasks
ttuegel
ttuegel requested changes Dec 31, 2017
View reviewed changes
pkgs/misc/themes/arc-kde/default.nix
@@ -0,0 +1,15 @@
{ stdenv, fetchFromGitHub }:

stdenv.mkDerivation rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a meta attribute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not really sure what I was thinking.

I was working on this for myself and forgot to add the meta stuff before I pushed.

@joachifm
Copy link
Contributor

Not a blocker, but have you considered making this fixed-output?

@nixy
Copy link
Contributor Author

nixy commented Jan 9, 2018

@ttuegel
I've added a meta attribute and made this into a fixed-output derivation now. Anything else I need to do here?

@ttuegel ttuegel merged commit 0dec14b into NixOS:master Jan 10, 2018
@ttuegel
Copy link
Member

ttuegel commented Jan 10, 2018

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nixy @joachifm @ttuegel @GrahamcOfBorg