Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcron module: be compatible with non-wrapped sendmail's, like opensmt… #33227

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Dec 31, 2017

Motivation for this change

Make fcron compatible with opensmtpd, which does not have a wrapped sendmail.

I've tested fcron now works correctly on opensmtpd-based systems, not that it still works on non-opensmtpd-based systems (as I don't have any), but the test of isSendmailWrapped should make the behaviour correct in this case too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm requested a review from Mic92 January 1, 2018 20:15
@Mic92 Mic92 merged commit 54b16bc into NixOS:master Jan 2, 2018
@Ekleog Ekleog deleted the fcron-opensmtpd branch January 2, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants