Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wsjtx: init at 1.8.0 #33247

Merged
merged 2 commits into from Feb 17, 2018
Merged

wsjtx: init at 1.8.0 #33247

merged 2 commits into from Feb 17, 2018

Conversation

lasandell
Copy link
Contributor

@lasandell lasandell commented Dec 31, 2017 •
edited

Motivation for this change

Add popular WSJT-X program for ham radio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Jan 10, 2018
View reviewed changes
pkgs/applications/misc/wsjtx/default.nix Outdated
buildInputs = [ fftw fftwFloat libusb1 qtbase qtmultimedia qtserialport ];

# Composite build has its own patch step after it extracts the inner archives
patchPhase = "cp ${./wsjtx.patch} wsjtx.patch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using postPatch instead still allows one to pass in patches

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've added a commit that uses postPatch instead of patchPhase.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build wsjtx

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘wsjtx-1.8.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/wsjtx/default.nix:27 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0/bin/fmeasure
shrinking /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0/bin/rigctl-wsjtx
shrinking /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0/bin/rigctld-wsjtx
gzipping man pages under /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0/bin
patching script interpreter paths in /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0
checking for references to /build in /nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0...
postPatchMkspecs
/nix/store/f4zgviwmdjm9hr3qcqi3z8ivmp477lhg-wsjtx-1.8.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0/bin/message_aggregator
shrinking /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0/bin/udp_daemon
shrinking /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0/bin/wsjtx
gzipping man pages under /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0/bin
patching script interpreter paths in /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0
checking for references to /build in /nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0...
postPatchMkspecs
/nix/store/603zqxj4gxirazdg9birk5730530z3gn-wsjtx-1.8.0

@joachifm joachifm merged commit 635011f into NixOS:master Feb 17, 2018
@lasandell lasandell deleted the wsjtx branch February 15, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lasandell @joachifm @GrahamcOfBorg @FRidh @Janik-Haag