Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diskrsync: init at 20170927 #33237

Merged
merged 2 commits into from Feb 7, 2018
Merged

diskrsync: init at 20170927 #33237

merged 2 commits into from Feb 7, 2018

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Dec 31, 2017 •
edited

Motivation for this change

NOTE: Do not merge yet. This is work in progress, doesn't work yet. I hope to get some help and feedback here. Fixed. Feel free to merge.

Diskrsync is rsync for block devices and disk images: https://github.com/dop251/diskrsync

I get the following error when trying to build: Fixed. I had a typo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine changed the title diskrsync: init at 20170927 diskrsync: init at 20170927 [WIP] Dec 31, 2017
@jluttine jluttine changed the title diskrsync: init at 20170927 [WIP] diskrsync: init at 20170927 Dec 31, 2017
@jluttine
Copy link
Member Author

I fixed the issue I originally had. Was just a stupid minor typo.

nlewo
nlewo requested changes Jan 16, 2018
View reviewed changes
pkgs/tools/backup/diskrsync/default.nix Outdated

name = "${pname}-${version}";
pname = "diskrsync";
version = "20170927";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the name format NAME-unstable-YYYY-MM-DD as specified in https://nixos.org/nixpkgs/manual/#sec-package-naming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jluttine
Copy link
Member Author

jluttine commented Feb 4, 2018

Updated the package.

@grahamc
Copy link
Member

grahamc commented Feb 6, 2018

@GrahamcOfBorg build diskrsync

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qksl7nfpci8cz41kr2lld47lj320j0z4-diskrsync-unstable-2018-02-03-bin/bin
patching script interpreter paths in /nix/store/qksl7nfpci8cz41kr2lld47lj320j0z4-diskrsync-unstable-2018-02-03-bin
checking for references to /build in /nix/store/qksl7nfpci8cz41kr2lld47lj320j0z4-diskrsync-unstable-2018-02-03-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/f2zk3k1n1q0plkan9p9lgjbbia03n74j-diskrsync-unstable-2018-02-03
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/f2zk3k1n1q0plkan9p9lgjbbia03n74j-diskrsync-unstable-2018-02-03
checking for references to /build in /nix/store/f2zk3k1n1q0plkan9p9lgjbbia03n74j-diskrsync-unstable-2018-02-03...
/nix/store/qksl7nfpci8cz41kr2lld47lj320j0z4-diskrsync-unstable-2018-02-03-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/39zqcq6a6n0dbqwxhjm6ysni0xabhql1-diskrsync-unstable-2018-02-03-bin/bin 
patching script interpreter paths in /nix/store/39zqcq6a6n0dbqwxhjm6ysni0xabhql1-diskrsync-unstable-2018-02-03-bin
checking for references to /tmp/nix-build-diskrsync-unstable-2018-02-03.drv-0 in /nix/store/39zqcq6a6n0dbqwxhjm6ysni0xabhql1-diskrsync-unstable-2018-02-03-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/h229q6mf242f6bxixqpqb16vsp7p3jxd-diskrsync-unstable-2018-02-03
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/h229q6mf242f6bxixqpqb16vsp7p3jxd-diskrsync-unstable-2018-02-03
checking for references to /tmp/nix-build-diskrsync-unstable-2018-02-03.drv-0 in /nix/store/h229q6mf242f6bxixqpqb16vsp7p3jxd-diskrsync-unstable-2018-02-03...
/nix/store/39zqcq6a6n0dbqwxhjm6ysni0xabhql1-diskrsync-unstable-2018-02-03-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

installing
/private/tmp/nix-build-diskrsync-unstable-2018-02-03.drv-0/go /private/tmp/nix-build-diskrsync-unstable-2018-02-03.drv-0
/private/tmp/nix-build-diskrsync-unstable-2018-02-03.drv-0
post-installation fixup
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lr5prsyamx6cabq3l78r6w2kicg8lhsv-diskrsync-unstable-2018-02-03-bin/bin
patching script interpreter paths in /nix/store/lr5prsyamx6cabq3l78r6w2kicg8lhsv-diskrsync-unstable-2018-02-03-bin
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/1zjsd8alxqr2sw4iqwy245x78qm4v8rx-diskrsync-unstable-2018-02-03
/nix/store/lr5prsyamx6cabq3l78r6w2kicg8lhsv-diskrsync-unstable-2018-02-03-bin

@grahamc grahamc merged commit c46c2e2 into NixOS:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @grahamc @GrahamcOfBorg @nlewo