Stop sending spaces in licenses to CKAN #180
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@politas, do we have a dev contact on the SpaceDock team? This is a minor fix, but it would reduce the number of metadata PRs needing manual tweaking. |
|
I've pinged @V1TA5 and Thomas on their IRC channel. |
|
Looks good to me, merging it. But I don't know when VITAS will be able to deploy it. |
|
Oh, wait, now that I look at the branches: @HebaruSan Could you resubmit this to master? The code that is currently active on SpaceDock is there, the stuff in dev was abadoned when we started the rewrite. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetKAN has been receiving a number of SpaceDock pull requests with license strings that don't match what CKAN uses. This happens for the various Creative Commons licenses; SpaceDock uses a space after the CC, while CKAN expects a hyphen.
Latest example here ("CC BY-NC-SA 3.0" vs "CC-BY-NC-SA-3.0"):
This pull request replaces all spaces in a license string to be sent to CKAN with hyphens.