Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c082544a5208
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 73a0d95b96d9
Choose a head ref
  • 5 commits
  • 1 file changed
  • 1 contributor

Commits on Dec 22, 2017

  1. chrootenv: print sysctl command for Debian users, fixes #32876

    @lukateras
    lukateras committed Dec 22, 2017
    Copy the full SHA
    ef1acca View commit details
    Browse the repository at this point in the history

  2. chrootenv: bind-mount all dirs in /, symlink files, closes #32877

    @lukateras
    lukateras committed Dec 22, 2017
    Copy the full SHA
    c03663a View commit details
    Browse the repository at this point in the history

  3. chrootenv: replace env whitelist with blacklist, closes #32878

    @lukateras
    lukateras committed Dec 22, 2017
    Copy the full SHA
    0234cd4 View commit details
    Browse the repository at this point in the history

  4. chrootenv: error on chrootenv-inside-chrootenv, resolves #32802

    @lukateras
    lukateras committed Dec 22, 2017
    Copy the full SHA
    710662b View commit details
    Browse the repository at this point in the history

  5. chrootenv: code review 

    * Wrap LEN macro in parantheses
* Drop env_filter in favor of stateful environ_blacklist_filter,
  use execvp instead of execvpe, don't explicitly use environ
* Add argument error logging wherever it makes sense
* Drop strjoin in favor of asprintf
* char* -> const char* where appropriate
* Handle stat errors
* Print user messages with fputs, not errorf
* Abstract away is_str_in (previously bind_blacklisted)
* Cleanup temporary directory on error
* Some minor syntactic and naming changes

Thanks to Jörg Thalheim and Tuomas Tynkkynen for the code review!
    @lukateras
    lukateras committed Dec 22, 2017
    Copy the full SHA
    73a0d95 View commit details
    Browse the repository at this point in the history