Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird: 52.5.0 -> 52.5.2 [Security fix] #32974

Merged
merged 2 commits into from Dec 22, 2017
Merged

thunderbird: 52.5.0 -> 52.5.2 [Security fix] #32974

merged 2 commits into from Dec 22, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Dec 22, 2017

Motivation for this change
  • Security fix

https://www.mozilla.org/en-US/thunderbird/52.5.2/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@taku0 taku0 changed the title Thunderbird bin 52.5.2 [Security fix] thunderbird: 52.5.0 -> 52.5.2 [Security fix] Dec 22, 2017
@vcunat vcunat added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 22, 2017
@vcunat vcunat self-assigned this Dec 22, 2017
vcunat
vcunat approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to run OK.

@vcunat vcunat merged commit 62c5b71 into NixOS:master Dec 22, 2017
vcunat added a commit that referenced this pull request Dec 22, 2017
@vcunat
Merge #32974: thunderbird: 52.5.0 -> 52.5.2 (security)
c082544
vcunat added a commit that referenced this pull request Dec 22, 2017
@vcunat
Merge #32974: thunderbird: 52.5.0 -> 52.5.2 (security)
9b44037 
(cherry picked from commit c082544)
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @GrahamcOfBorg