Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winusb: unstable-2017-01-30 -> woeusb 3.1.4 #32965

Merged
merged 1 commit into from Dec 22, 2017
Merged

winusb: unstable-2017-01-30 -> woeusb 3.1.4 #32965

merged 1 commit into from Dec 22, 2017

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Dec 22, 2017

Motivation for this change

WinUSB was renamed to WoeUSB (https://github.com/slacka/WoeUSB/issues/100).

Also, put mount points in /run instead of /tmp to sidestep security considerations with /tmp.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

andersk
andersk commented Dec 22, 2017
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -5216,7 +5216,8 @@ with pkgs;

which = callPackage ../tools/system/which { };

winusb = callPackage ../tools/misc/winusb { };
woeusb = callPackage ../tools/misc/woeusb { };
winusb = woeusb; # renamed June 2017
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this alias belong in aliases.nix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@andersk
winusb: unstable-2017-01-30 -> woeusb 3.1.4
4ef36bf 
WinUSB was renamed to WoeUSB
(https://github.com/slacka/WoeUSB/issues/100).

Also, put mount points in /run instead of /tmp to sidestep security
considerations with /tmp.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@FRidh FRidh merged commit 7a0fab3 into NixOS:master Dec 22, 2017
@andersk andersk deleted the woeusb branch December 23, 2017 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @FRidh @GrahamcOfBorg