rhvoice: init at 0.5 #32979

berce · 2017-12-22T14:45:08Z

Motivation for this change

RHVoice is one of the best speech synthesis engines I 've heard, including commercial ones.
It can be tested with echo "Talk to me" | RHVoice-test.

Things done

Win the battle against scons to gain power over the environment.
Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

jtojnar · 2017-12-22T21:55:53Z

pkgs/applications/audio/rhvoice/default.nix

+{ stdenv, lib, pkgconfig, fetchFromGitHub, scons, python, glibmm, libao
+}:
+
+with lib;


This is not used anywhere.

In the meta attribute.
Moved.

jtojnar · 2017-12-22T21:56:03Z

pkgs/applications/audio/rhvoice/default.nix

+with lib;
+stdenv.mkDerivation rec {
+  name = "rhvoice";
+  #version = "2017-09-24";


This is not needed.

Removed.
I hope to update to that version soon though, 0.5 is several years old.

jtojnar · 2017-12-22T21:56:26Z

pkgs/applications/audio/rhvoice/default.nix

+
+with lib;
+stdenv.mkDerivation rec {
+  name = "rhvoice";


Derivation name should contain the version.

jtojnar · 2017-12-22T22:06:10Z

pkgs/applications/audio/rhvoice/default.nix

+  #    - RPATH, to link to the newly built libraries
+  # 2. Some data is being zipped. Zip can't handle files from 1970.
+  #
+  postPatch = ''


Could you make this a proper patch?

jtojnar · 2017-12-22T22:06:25Z

pkgs/applications/audio/rhvoice/default.nix

+            env["BUILDDIR"]=BUILDDIR
+            env["RPATH"]="'$out'/lib"
+    '
+    find "./" '!' -newermt '1980-01-01' -exec touch -d '1980-01-02' '{}' '+'


Why is this necessary?

Some data is being zipped. Zip can't handle files from 1970.

grahamc · 2017-12-23T12:40:47Z

@GrahamcOfBorg eval

(sorry for the noise, master was broken by a merge)

jtojnar · 2017-12-24T03:30:43Z

pkgs/development/libraries/speechd/default.nix

+    substituteInPlace config/speechd.conf --replace "nixDefault" "${selectedDefaultModule}"
+    substituteInPlace config/speechd.conf --replace "sd_rhvoice" "${rhvoice}/bin/sd_rhvoice"
+    substituteInPlace config/speechd.conf --replace "RHVoice.conf" "${rhvoice}/etc/RHVoice/RHVoice.conf"
+    ${stdenv.lib.optionalString withPico ''


This conditional is not needed since the svox dependency can be compiled out. RHVoice, on the other hand, cannot so that one should get a conditional. Though, I would move enabling the rhvoice to a NixOS module.

I rearranged the optional stuff in patches and postPatch. Is that what you wanted?

Since speech-dispatcher ships with several speech engines, I think including RHVoice in the same way is convenient for the user. Would a NixOS module not make it only available in NixOS?

jtojnar · 2018-03-19T05:34:55Z

I remain unconvinced that rhvoice should be part of the speechd expression.

GrahamcOfBorg · 2018-03-19T05:44:34Z

Failure on x86_64-linux (full log)

Attempted: rhvoice

Partial log (click to expand)

src/include/core/xml.hpp: In instantiation of 'void RHVoice::xml::parser<ch>::parse(const input_iterator&, const input_iterator&, RHVoice::document&) [with input_iterator = const wchar_t*; ch = wchar_t]':
src/include/core/document.hpp:575:5:   required from 'static std::auto_ptr<RHVoice::document> RHVoice::document::create_from_ssml(const RHVoice::smart_ptr<RHVoice::engine>&, const input_iterator&, const input_iterator&, const RHVoice::voice_profile&) [with input_iterator = const wchar_t*]'
src/lib/lib.cpp:221:41:   required from 'RHVoice_message_struct::RHVoice_message_struct(const RHVoice::smart_ptr<RHVoice::engine>&, const RHVoice_callbacks&, const ch*, unsigned int, RHVoice_message_type, const RHVoice_synth_params*, void*) [with ch = wchar_t]'
src/lib/lib.cpp:117:13:   required from 'RHVoice_message_struct* RHVoice_tts_engine_struct::new_message(const ch*, unsigned int, RHVoice_message_type, const RHVoice_synth_params*, void*) const [with ch = wchar_t; RHVoice_message = RHVoice_message_struct*]'
src/lib/lib.cpp:332:98:   required from here
src/include/core/xml.hpp:361:20: error: invalid operands of types '<unresolved overloaded function type>' and 'const int' to binary 'operator<'
scons: *** [build/linux/lib/lib.os] Error 1
scons: building terminated because of errors.
builder for '/nix/store/wnhdrym0srydif48khszhxllja1ri5p5-rhvoice-0.5.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/wnhdrym0srydif48khszhxllja1ri5p5-rhvoice-0.5.drv' failed

GrahamcOfBorg · 2018-03-19T05:50:44Z

Failure on aarch64-linux (full log)

Attempted: rhvoice

Partial log (click to expand)

src/include/core/xml.hpp: In instantiation of 'void RHVoice::xml::parser<ch>::parse(const input_iterator&, const input_iterator&, RHVoice::document&) [with input_iterator = const wchar_t*; ch = wchar_t]':
src/include/core/document.hpp:575:5:   required from 'static std::auto_ptr<RHVoice::document> RHVoice::document::create_from_ssml(const RHVoice::smart_ptr<RHVoice::engine>&, const input_iterator&, const input_iterator&, const RHVoice::voice_profile&) [with input_iterator = const wchar_t*]'
src/lib/lib.cpp:221:41:   required from 'RHVoice_message_struct::RHVoice_message_struct(const RHVoice::smart_ptr<RHVoice::engine>&, const RHVoice_callbacks&, const ch*, unsigned int, RHVoice_message_type, const RHVoice_synth_params*, void*) [with ch = wchar_t]'
src/lib/lib.cpp:117:13:   required from 'RHVoice_message_struct* RHVoice_tts_engine_struct::new_message(const ch*, unsigned int, RHVoice_message_type, const RHVoice_synth_params*, void*) const [with ch = wchar_t; RHVoice_message = RHVoice_message_struct*]'
src/lib/lib.cpp:332:98:   required from here
src/include/core/xml.hpp:361:20: error: invalid operands of types '<unresolved overloaded function type>' and 'const int' to binary 'operator<'
scons: *** [build/linux/lib/lib.os] Error 1
scons: building terminated because of errors.
builder for '/nix/store/7fwigv7w55708vq8hszz7znfgvjhiidn-rhvoice-0.5.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/7fwigv7w55708vq8hszz7znfgvjhiidn-rhvoice-0.5.drv' failed

jtojnar · 2018-03-19T06:00:44Z

Right, I am fine with rhvoice as is, but third-party speech modules should be enabled through NixOS module.

jtojnar · 2018-03-19T13:16:40Z

Merged the updated rhvoice as f97c466

c0bw3b · 2018-10-21T18:03:19Z

@jtojnar should we close this since #37370 is merged?
A speechd module for rhvoice will probably go through a new PR anyway

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 22, 2017

jtojnar added the 6.topic: accessibility label Dec 22, 2017

jtojnar requested changes Dec 22, 2017

View reviewed changes

berce force-pushed the upstream-rhvoice branch from d2df41d to 16f32aa Compare December 23, 2017 15:23

berce changed the title ~~rhvoice: init at 2017-09-24~~ rhvoice: init at 0.5 Dec 23, 2017

berce added 5 commits December 23, 2017 22:58

rhvoice: init at 2017-09-24

e4249c5

rhvoice: remove

1f6feaf

rhvoice: add version to name

d80a767

rhvoice: remove commented version

23a8266

rhvoice: use proper patch

9b0d45a

berce force-pushed the upstream-rhvoice branch 2 times, most recently from 34e4a22 to f0299c5 Compare December 23, 2017 22:31

speechd: add rhvoice support

6709b92

berce force-pushed the upstream-rhvoice branch from f0299c5 to 6709b92 Compare December 23, 2017 22:35

jtojnar reviewed Dec 24, 2017

View reviewed changes

speechd: rearrange optionals in patches and postPatch

2e034c5

berce force-pushed the upstream-rhvoice branch from 863b5b5 to 2e034c5 Compare December 24, 2017 07:32

GrahamcOfBorg added the 8.has: package (new) label Mar 19, 2018

jtojnar mentioned this pull request Apr 25, 2018

Add speechd module #39500

Open

jtojnar closed this Oct 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rhvoice: init at 0.5 #32979

rhvoice: init at 0.5 #32979

berce commented Dec 22, 2017

jtojnar Dec 22, 2017

berce Dec 23, 2017

jtojnar Dec 22, 2017

berce Dec 23, 2017

jtojnar Dec 22, 2017

berce Dec 23, 2017

jtojnar Dec 22, 2017

berce Dec 23, 2017

jtojnar Dec 22, 2017

berce Dec 23, 2017

grahamc commented Dec 23, 2017

jtojnar Dec 24, 2017

berce Dec 24, 2017

jtojnar commented Mar 19, 2018

GrahamcOfBorg commented Mar 19, 2018

GrahamcOfBorg commented Mar 19, 2018

jtojnar commented Mar 19, 2018

jtojnar commented Mar 19, 2018

c0bw3b commented Oct 21, 2018

rhvoice: init at 0.5 #32979

rhvoice: init at 0.5 #32979

Conversation

berce commented Dec 22, 2017

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grahamc commented Dec 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Mar 19, 2018

GrahamcOfBorg commented Mar 19, 2018

GrahamcOfBorg commented Mar 19, 2018

jtojnar commented Mar 19, 2018

jtojnar commented Mar 19, 2018

c0bw3b commented Oct 21, 2018