Added a gstreamer in dependencies #32975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added gstreamer in dependencies. Gstreamer used to play music from url.
ghost
changed the title
FRidh
requested changes
Dec 22, 2017
There was a problem hiding this comment.
Please check the contributing guidelines on naming commits.
https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
jtojnar
requested changes
Dec 22, 2017
There was a problem hiding this comment.
Adding an argument to derivation function is not enough to register a dependency, you also need to add it to buildInputs or such. Morever, gstreamer attribute contains the legacy version of GStreamer, the one Rhytmbox needs is in gst_all_1.gstreamer which is already there:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gstreamer in dependencies. Gstreamer used in Rhytmbox to play music from URL's.
Motivation for this change
Things done
Tested using sandboxing (nix.useSandbox) on NixOS
Built on platform(s)
Tested execution of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.