Erlang cleanup (remove R17, R16 cleanup, updated couchdb to R19) #32454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlangR17 is no longer receiving any kind of (security) patches, switching to R19 should be fine as per the couchdb documentation [1] [1] http://docs.couchdb.org/en/2.1.1/install/unix.html#dependencies
Also renamed the file since it is no longer version 8.
erlangR17 doesn't receive any upstream updates anymore and none of our packages depend on it.
LnL7
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is mostly a followup to #32443.
erlangR16in 2b72043 theR16.nixfile remained in the repository. This PR contains a commit that removes the file.erlangR17(couchdb) toerlangR19which is the latest supported version according to thecouchdbdocumentation.erlang17has been removed.erlang_basho_R16B02derivation was updated to the latest available version. Since there are users of that package (riak,riak-cc, …) that is probably appropriate despite it being marked asinsecure.versionattribute of the derivation was updated so that the derived name of the package reflects the used patch version.Things done
build-use-sandboxinnix.confon non-NixOS)nixos/tests/couchdb.nixsucceedsnixos/tests/riak.nixfailed, also failed on latest unstable channel, 17.09 and 17.03, … see nixos/tests/riak.nix fails on master, 17.09 & 17.03 #32453nix-shell -p nox --run "nox-review wip"./result/bin/)