Erlang CVE-2017-1000385 erlangR{18,19,20} #32443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sgtm to drop R16 and R17. R16-basho is most likely a dependency of Riak, so
should stay if that’s the case
…On Fri, 8 Dec 2017 at 10:46, Andreas Rammhold ***@***.***> wrote:
Motivation for this change
Closing CVE-2017-1000385 in erlangR{18,19,20}.
We are also carrying versions of R16, R16-basho & R17 around that are no
longer receiving any kinds of updates as far as I can tell.
It should be considered to remove those or at least mark them as
unsupported (meta.broken = true, …).
CC maintainers: @the-kenny <https://github.com/the-kenny> @sjmackenzie
<https://github.com/sjmackenzie> @couchemar <https://github.com/couchemar>
@gleber <https://github.com/gleber>
Things done
- Tested using sandboxing (nix.useSandbox
<http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox> on
NixOS, or option build-use-sandbox in nix.conf
<http://nixos.org/nix/manual/#sec-conf-file> on non-NixOS)
- Built on platform(s)
- NixOS
- macOS
- other Linux distributions
- Tested via one or more NixOS test(s) if existing and applicable for
the change (look inside nixos/tests
<https://github.com/NixOS/nixpkgs/blob/master/nixos/tests>)
- Tested compilation of all pkgs that depend on this change using nix-shell
-p nox --run "nox-review wip"
- Tested execution of all binary files (usually in ./result/bin/)
- Fits CONTRIBUTING.md
<https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md>.
------------------------------
------------------------------
You can view, comment on, or merge this pull request online at:
#32443
Commit Summary
- erlangR20: 20.1 -> 20.1.7 (fixes CVE-2017-1000385)
- erlangR19: 19.3 -> 19.3.6.4 (fixes CVE-2017-1000385)
- erlangR18: 18.3.4.4 -> 18.3.4.7 (fixes CVE-2017-1000385)
File Changes
- *M* pkgs/development/interpreters/erlang/R18.nix
<https://github.com/NixOS/nixpkgs/pull/32443/files#diff-0> (4)
- *M* pkgs/development/interpreters/erlang/R19.nix
<https://github.com/NixOS/nixpkgs/pull/32443/files#diff-1> (4)
- *M* pkgs/development/interpreters/erlang/R20.nix
<https://github.com/NixOS/nixpkgs/pull/32443/files#diff-2> (4)
Patch Links:
- https://github.com/NixOS/nixpkgs/pull/32443.patch
- https://github.com/NixOS/nixpkgs/pull/32443.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32443>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACBoV4-TfoXJNpBvwhdeVbeyfoOrVdOks5s-QWJgaJpZM4Q62Cd>
.
|
|
Packages can be marked as insecure. Are R16 and R17 still used by other stuff? |
erlangR16 doesn't receive any upstream updates anymore and none of our packages depend on it.
|
There wasn't any package depending on erlangR17 or R16 so I added two commits removing those versions. |
|
@GrahamcOfBorg eval |
|
oh, that one is obvious... |
|
So apparently I could probably just bump that as well... It seems to move out of scope for this PR tho.. |
|
Can you drop the R17 commit, then we should be able to merge it. |
andir
force-pushed
the
erlang-cve-2017-1000385
branch
from
4566a07
to
2b72043
Compare
|
done |
LnL7
approved these changes
Dec 8, 2017
LnL7
added
the
8.has: port to stable
|
Backported to 17.09 in 414c57b etc. |
andir
added a commit
to andir/nixpkgs
that referenced
this pull request
Dec 8, 2017
10 tasks
LnL7
pushed a commit
that referenced
this pull request
Dec 9, 2017
(cherry picked from commit b8b4d7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closing CVE-2017-1000385 in erlangR{18,19,20}.
We are also carrying versions of R16, R16-basho & R17 around that are no longer receiving any kinds of updates as far as I can tell.
It should be considered to remove those or at least mark them as unsupported (
meta.broken = true, …).CC maintainers: @the-kenny @sjmackenzie @couchemar @gleber
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)