nginxModules.ModSecurity-beta: 2017-06-17 -> 2017-08-23 #32449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 9, 2017
pkgs/servers/http/nginx/modules.nix
Outdated
| @@ -47,12 +47,12 @@ | |||
| ''; | |||
| }; | |||
|
|
|||
| modsecurity-beta = { | |||
| modsecurity-nginx = { | |||
There was a problem hiding this comment.
the stable version above is called modsecurity. Renaming this one to modsecurity-nginx will lead to confusion.
Izorkin
force-pushed
the
ModSecurity-nginx
branch
from
f381c36
to
2c7912c
Compare
|
Fixed commit |
Mic92
reviewed
Dec 10, 2017
| rev = "abbf2c47f6f3205484a1a9db618e067dce213b89"; | ||
| sha256 = "04ar51bnqjca6g4p2irymgdmc8rh5nsi8ml43srm4krllnkvw8qn"; | ||
| rev = "a2a5858d249222938c2f5e48087a922c63d7f9d8"; | ||
| sha256 = "1zj0fq35hddzf7b3x40xlbss866lg7w2vd1bbm8g1hcq1ny2s84n"; | ||
| }; | ||
| inputs = [ pkgs.curl pkgs.geoip pkgs.libmodsecurity pkgs.libxml2 pkgs.lmdb pkgs.yajl ]; |
There was a problem hiding this comment.
There is no libmodsecurity package. Is modsecurity_standalone wanted here instead?
How did you test this?
There was a problem hiding this comment.
Need this PR - #32075
|
I wonder, why bump the revision? Not saying we shouldn't but it's not clear why one revision would be better than another, so it'd be nice to have that noted in the commit message. |
Izorkin
changed the title
Izorkin
changed the title
Izorkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update nginx modules ModSecurity-beta to recent version
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)