Fixing #2931 #3059
Merged
Fixing #2931 #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kleinhenz could you verify if this fixes the issue for you? |
|
Yes fixed for me. Thanks! |
hkaiser
reviewed
Dec 9, 2017
src/hpx_init.cpp
Outdated
| // (if the program options contain --hpx:help or --hpx:version) | ||
| if (rp.terminate_after_parse()) | ||
| { | ||
| return result; |
There was a problem hiding this comment.
Why have you remove conditionally setting of the result value to zero?
There was a problem hiding this comment.
Because it's always zero at this point in time as far as I can see.
There was a problem hiding this comment.
You're right. The code as it is right now leaves result unchanged after it was initialized. This is a leftover problem from our move to the resource_partitioner, though. I'll try to come up with a patch against this PR to fix things.
|
Thanks Hartmut, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime termination in the presence of --hpx:help or --hpx:version needs to
happen after the runtime has been initialized.