Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcurse: 4.2.0 -> 4.3.0 #33036

Merged
merged 2 commits into from Dec 26, 2017
Merged

calcurse: 4.2.0 -> 4.3.0 #33036

merged 2 commits into from Dec 26, 2017

Conversation

langston-barrett
Copy link
Contributor

Motivation for this change
Things done
  • Update calcurse
  • Fix calcurse-caldav. It previously just executed python3, but now successfully executes with the proper dependencies. I would appreciate feedback on the best way to patch the shebang, this was just the one I figured out
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 26, 2017

@GrahamcOfBorg build calcurse

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘calcurse-4.3.0’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/calcurse/default.nix:26 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

make[1]: Leaving directory '/build/calcurse-4.3.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0
shrinking /nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0/bin/calcurse
gzipping man pages under /nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0/share/man/
stripping (with flags -S) in /nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0/bin
patching script interpreter paths in /nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0
/nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0/bin/calcurse-upgrade: interpreter directive changed from "/bin/sh" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0...
/nix/store/pszskpid0pf90g4q874mpqlz19lpk3b4-calcurse-4.3.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

make[1]: Leaving directory '/tmp/nix-build-calcurse-4.3.0.drv-0/calcurse-4.3.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0
shrinking /nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0/bin/calcurse
gzipping man pages under /nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0/share/man/
stripping (with flags -S) in /nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0/bin 
patching script interpreter paths in /nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0
/nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0/bin/calcurse-upgrade: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-calcurse-4.3.0.drv-0 in /nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0...
/nix/store/dzg54bjhmbwl8anl0j9w5wh2xxrlx3ma-calcurse-4.3.0

@grahamc grahamc merged commit c9ec073 into NixOS:master Dec 26, 2017
@langston-barrett langston-barrett deleted the calcurse branch December 26, 2017 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants