Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse slash after open-paren as regex delimiter #5453

Merged
merged 1 commit into from Apr 10, 2018
Merged

Parse slash after open-paren as regex delimiter #5453

merged 1 commit into from Apr 10, 2018

Conversation

makenowjust
Copy link
Contributor

Fixed #5411

@Sija
Copy link
Contributor

Sija commented Apr 9, 2018

🏓, anyone?

RX14
RX14 approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪲🔨

@makenowjust
Copy link
Contributor Author

@RX14 "tread on a worm and it will turn." 😜

@bcardiff bcardiff added this to the Next milestone Apr 10, 2018
@bcardiff bcardiff merged commit 27697cf into crystal-lang:master Apr 10, 2018
@makenowjust makenowjust deleted the fix/crystal/parse-slash-in-paren-as-regexp branch April 10, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makenowjust @Sija @jhass @RX14 @bcardiff