linux-steam-integration: init at 0.7.2 #33051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Dec 25, 2017
| }; | ||
|
|
||
| steamBinPath = "${stdenv.lib.makeBinPath (with pkgs; [ steam ])}/steam"; | ||
| zenityBinPath = "${stdenv.lib.makeBinPath (with pkgs; [ zenity ])}/zenity"; |
There was a problem hiding this comment.
these two can go in a let expression since they're not actual arguments for mkDerivation
etu
force-pushed
the
linux-steam-integration
branch
3 times, most recently
from
010c358
to
37fa40c
Compare
etu
changed the title
|
Since I got the 32bit parts to build I think this PR is ready. It at least works on my 64bit systems and don't complain about missing 32bit libraries when running lsi-steam. |
etu
force-pushed
the
linux-steam-integration
branch
7 times, most recently
from
915e76d
to
d85c9f7
Compare
|
cc @jagajaga, any opinions on this? |
|
Cc @abbradar |
etu
force-pushed
the
linux-steam-integration
branch
3 times, most recently
from
b3258a2
to
105f8f5
Compare
adisbladis
requested changes
Jan 3, 2018
| homepage = https://github.com/solus-project/linux-steam-integration; | ||
| license = licenses.lgpl21; | ||
| maintainers = [ maintainers.etu ]; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
Should be platforms = [ "x86_64-linux" ];.
stdenv.lib.platforms.linux includes mips and arm arches where steam does not run.
| name = "linux-steam-integration-${version}"; | ||
|
|
||
| nativeBuildInputs = [ meson ninja pkgconfig git gettext gcc_multi ]; | ||
| buildInputs = [ pkgs.gtk3 libressl ]; |
There was a problem hiding this comment.
It is better to take gtk3 as an argument rather than using gtk3 from the pkgs attribute set.
etu
force-pushed
the
linux-steam-integration
branch
from
105f8f5
to
bfd4036
Compare
etu
force-pushed
the
linux-steam-integration
branch
from
bfd4036
to
d732c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Linux Steam Integration is the foundation of the work that the Solus Project have done to get steam to "work better" on their OS. It seems like they solve a lot of problems with their wrappers and things.
Things to solve:
Here's the script used by archlinux to see how they build it both as 64 and 32 bit. https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=linux-steam-integration
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)