cc @msteen

Seems good to me.

BTW, I was just the one who packaged Google Chrome first. I would not consider myself an actual maintainer of it. I do not test new releases or have any rights to merge, so maybe someone else should become the maintainer?

@msteen as long as you care somewhat about the package & can answer questions about it, I think it makes sense for you to be a maintainer. For something like this we should have an "active" maintainer as well, though ...

Please backport this to stable, otherwise today's update to 64 will break Google Crhome there entirely.

cc @bendlas @vcunat

What needs to happen? Just make a new pull request to release-17.09? The patch cherry-picks cleanly onto that branch.

You can create a patch with cherry-pick -x and submit a PR against the release branch

Like this?

#34283

Installed the Chrome on Cent OS using:

$ curl https://intoli.com/install-google-chrome.sh | bash
# from https://intoli.com/blog/installing-google-chrome-on-centos/

The version:

$ google-chrome-stable --version
Google Chrome 64.0.3282.119

The issue:

> Cannot start ChromeHeadless
> .../node_modules/puppeteer/.local-chromium/linux-526987/chrome-linux/chrome: error while loading shared libraries: libatk-bridge-2.0.so.0: cannot open shared object file: No such file or directory

Not fully sure, the issue is expected to be fixed soon (next version of google-chrome-stable), or the dependency should be added?
Discussed in puppeteer/puppeteer#765 @sangaline

Is that a centos issue, a nix issue, a node issue, or a puppeteer issue?
If your 'google-chrome-stable --version' works, you have all the dependencies it needs.

The google-chrome-stable is setting LD_LIBRARY_PATH=/opt/google/chrome/lib and using the /opt/google/chrome/chrome executable (which has been patched to use a relocated linker in /opt/google/chrome/lib/). If the Chromium binary that Puppeteer downloaded is being used then it won't know where to find these dependencies. You'll likely need to set LD_LIBRARY_PATH and use the /opt/google/chrome/chrome executable with Puppeteer in order to get it to work.